Skip to content

Add note concerning subnormal numbers#341

Merged
kgryte merged 1 commit into
mainfrom
subnormals
Dec 6, 2021
Merged

Add note concerning subnormal numbers#341
kgryte merged 1 commit into
mainfrom
subnormals

Conversation

@kgryte

@kgryte kgryte commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

This PR

  • resolves Improve subnormal expectations #339.
  • relaxes IEEE 754 requirements for supporting subnormal numbers.
  • stems from the need to allow conforming implementations to disable subnormal number support for performance and/or security reasons.

@kgryte kgryte added the API change Changes to existing functions or objects in the API. label Dec 6, 2021
@kgryte kgryte added this to the v2021 milestone Dec 6, 2021

@honno honno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy to see this PR 😅

@kgryte

kgryte commented Dec 6, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, @honno!

@kgryte

kgryte commented Dec 6, 2021

Copy link
Copy Markdown
Contributor Author

The changes in this PR have been discussed elsewhere. Will merge. Any further changes can be addressed in follow-up PRs.

@kgryte kgryte merged commit 0602a5f into main Dec 6, 2021
@kgryte kgryte deleted the subnormals branch December 6, 2021 19:46
@leofang

leofang commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

cc: @oleksandr-pavlyk for vis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change Changes to existing functions or objects in the API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve subnormal expectations

3 participants